pnowojski commented on a change in pull request #7688: [FLINK-9816][network] 
add option to configure SSL engine provider for TM communication
URL: https://github.com/apache/flink/pull/7688#discussion_r281140422
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/NettyClientServerSslTest.java
 ##########
 @@ -96,6 +108,7 @@ private void testValidSslConnection(Configuration 
sslConfig) throws Exception {
                // session context is only be available after a session was 
setup -> this should be true after data was sent
                SSLSessionContext sessionContext = 
sslHandler.engine().getSession().getSessionContext();
                assertNotNull("bug in unit test setup: session context not 
available", sessionContext);
+               // TODO: sessionContext is from the client side which may not 
have a session cache at all (with openSSL it behaves that way)
 
 Review comment:
   ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to