pnowojski commented on a change in pull request #7688: [FLINK-9816][network]
add option to configure SSL engine provider for TM communication
URL: https://github.com/apache/flink/pull/7688#discussion_r280771834
##########
File path:
flink-mesos/src/main/java/org/apache/flink/mesos/util/MesosArtifactServer.java
##########
@@ -135,7 +134,8 @@ protected void initChannel(SocketChannel ch) {
// SSL should be the first handler in the
pipeline
if (sslFactory != null) {
- ch.pipeline().addLast("ssl",
sslFactory.createNettySSLHandler());
+ ch.pipeline().addLast("ssl",
Review comment:
I do not understand this `[FLINK-9816][network] netty-fy SSL configuration`
commit. What does it do? There are no new tests, no changes in the existing
tests, no documentation and nothing in the commit message :(
Is it refactor? If so please explain in the commit message what are you
refactoring and why.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
