StefanRRichter commented on a change in pull request #8361:
[FLINK-12434][network] Replace listeners with CompletableFuture in InputGates
URL: https://github.com/apache/flink/pull/8361#discussion_r282057904
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -596,6 +600,12 @@ public void requestPartitions() throws IOException,
InterruptedException {
}
}
+ private void resetIsAvailable() {
+ if (isAvailable.isDone()) {
Review comment:
I think you can avoid a volatile read from inside `isDone()` by checking `if
(isAvailable == AVAILABLE)`. For clarity you might also an assertion or comment
that this method should only be called while holding the proper lock, or
annotate the field as guarded by lock.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
