StefanRRichter commented on a change in pull request #8361:
[FLINK-12434][network] Replace listeners with CompletableFuture in InputGates
URL: https://github.com/apache/flink/pull/8361#discussion_r282377627
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -551,21 +551,20 @@ public void requestPartitions() throws IOException,
InterruptedException {
}
currentChannel = inputChannelsWithData.remove();
-
enqueuedInputChannelsWithData.clear(currentChannel.getChannelIndex());
+
+ result = currentChannel.getNextBuffer();
+
+ if (result.isPresent() &&
result.get().moreAvailable()) {
+ // enqueue the currentChannel at the
end to avoid starvation
Review comment:
Yes you are right if you consider all commits. I made this comment with the
state of commit `b8309e1` in mind where it was first touched. So in the end you
can ignore it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
