StefanRRichter commented on a change in pull request #8361:
[FLINK-12434][network] Replace listeners with CompletableFuture in InputGates
URL: https://github.com/apache/flink/pull/8361#discussion_r282059667
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java
##########
@@ -171,8 +172,7 @@
/** Flag indicating whether all resources have been released. */
private volatile boolean isReleased;
- /** Registered listener to forward buffer notifications to. */
- private volatile InputGateListener inputGateListener;
+ private CompletableFuture<?> isAvailable = AVAILABLE;
Review comment:
Not sure if this already justifies an abstract class, but very strictly
speaking this field is already somewhat duplicated code between the single and
union input gate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
