azagrebin commented on a change in pull request #8416: [FLINK-12331] Introduce partition/gate setup to decouple task registration with NetworkEnvironment URL: https://github.com/apache/flink/pull/8416#discussion_r283341919
########## File path: flink-core/src/main/java/org/apache/flink/core/memory/MemorySegmentProvider.java ########## @@ -0,0 +1,34 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.core.memory; + +import java.io.IOException; +import java.util.Collection; + +/** + * The provider used for requesting and releasing batch of memory segments. + */ +public interface MemorySegmentProvider { + /** Requests default number of memory segments. */ + Collection<MemorySegment> requestMemorySegments() throws IOException; + + Collection<MemorySegment> requestMemorySegments(int numRequiredBuffers) throws IOException; Review comment: I think `MemorySegmentProvider` makes sense from point of interface segregation principle. This interface encapsulates segment management concern which is the only thing that remote channel needs atm. `NetworkBufferPool` looks like implementing 2 separate concerns: `BufferPoolFactory` and `MemorySegmentProvider`. As for `requestMemorySegments(int numRequiredBuffers)`, you are right, it is more clear to remove it from the interface and adjust the tests with explicit default value, e.g. 1. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
