azagrebin commented on a change in pull request #8416: [FLINK-12331] Introduce
partition/gate setup to decouple task registration with NetworkEnvironment
URL: https://github.com/apache/flink/pull/8416#discussion_r285339824
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/InputGateConcurrentTest.java
##########
@@ -88,7 +90,9 @@ public void testConsumptionWithRemoteChannels() throws
Exception {
final ConnectionManager connManager =
createDummyConnectionManager();
final Source[] sources = new Source[numberOfChannels];
- final SingleInputGate gate =
createSingleInputGate(numberOfChannels);
Review comment:
True, actually I do not mind short-hands. Though, I would remove one of
short-hands with 3 parameters. I think builder is more readable in case of many
parameters.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
