liyafan82 commented on issue #8397: [FLINK-11421][Table SQL/Runtime]Add 
compilation options to allow comp…
URL: https://github.com/apache/flink/pull/8397#issuecomment-492162446
 
 
   Hi @JingsongLi, thank you so much for your comments. I will provide the 
benchmark results, as we have discussed.
   The bug refers to OperatorCodeGenrator#generateTwoInputStreamOperator 
method. There should be a parameter with type TableConfig, so as to be align 
with generateOneInputStreamOperator. 
   I am not sure if you have left it out intentionally, or forgotten about it.
   
   Hi @KurtYoung , thanks a lot for your attention, and thank you for your 
effort in verifying our results. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to