liyafan82 commented on issue #8397: [FLINK-11421][Table SQL/Runtime]Add compilation options to allow comp… URL: https://github.com/apache/flink/pull/8397#issuecomment-492973322 > I think JMH benchmark component is a further thing. It's under discussion. > For this PR, I think you can do a simpler benchmark rather than a complicate component. > You can dependent https://github.com/dataArtisans/flink-benchmarks or other things, just let us reproduce your benchmark easier. > (you can also include testing for vector computation in this local benchmarks) @JingsongLi Thanks for your suggestion. flink-benchmarks is based on JMH. To add a performance benchmark, we need a separate project, not simply adding a dependency. So we need to open a separate project (if you know a way to add an individual performance benchmark without opening a new project, please let me know), and that is substantial change, which deserves a separate JIRA.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
