azagrebin commented on a change in pull request #8459: [FLINK-12476] [State
TTL] Consider setting a default background cleanup strategy in StateTtlConfig
URL: https://github.com/apache/flink/pull/8459#discussion_r285593576
##########
File path:
flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java
##########
@@ -360,6 +373,8 @@ public StateTtlConfig build() {
private static final CleanupStrategy EMPTY_STRATEGY = new
EmptyCleanupStrategy();
+ private boolean isCleanupInBackground = false;
Review comment:
Let's make it final. If we move `isCleanupInBackground` and `strategies` to
builder, we can make `CleanupStrategies` immutable by passing
`isCleanupInBackground` and `strategies` to `CleanupStrategies` constructor in
`builder.build()`. `CleanupStrategies` field can be removed from builder then.
`activate` and `setCleanupInBackground` are also not needed in
`CleanupStrategies`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
