azagrebin commented on a change in pull request #8459: [FLINK-12476] [State 
TTL] Consider setting a default background cleanup strategy in StateTtlConfig
URL: https://github.com/apache/flink/pull/8459#discussion_r285597490
 
 

 ##########
 File path: docs/dev/stream/state/state.md
 ##########
 @@ -432,9 +463,9 @@ val ttlConfig = StateTtlCon fig
 </div>
 </div>
 
-This strategy has two parameters. The first one is number of checked state 
entries per each cleanup triggering.
+This strategy has two parameters. The first one is number of checked state 
entries per each cleanup triggering (default: 10).
 If enabled, it is always triggered per each state access.
-The second parameter defines whether to trigger cleanup additionally per each 
record processing.
+The second parameter defines whether to trigger cleanup additionally per each 
record processing (default: true).
 
 Review comment:
   I would rather add an explicit sentence:
   `If you enable the default background cleanup then this strategy will be 
activated for heap backend with 5 checked entries and without cleanup per 
record processing.`
   Similar for rocks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to