twalthr commented on a change in pull request #8404: [FLINK-11476][table]
Create CatalogManager to manage multiple catalogs
URL: https://github.com/apache/flink/pull/8404#discussion_r285981574
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/Table.java
##########
@@ -812,33 +812,52 @@
Table fetch(int fetch);
/**
- * Writes the {@link Table} to a {@link TableSink} that was registered
under the specified name.
+ * Writes the {@link Table} to a {@link TableSink} that was registered
under the specified path.
+ * For the path resolution algorithm see {@link
TableEnvironment#useDatabase(String, String)}.
*
* <p>A batch {@link Table} can only be written to a
* {@code org.apache.flink.table.sinks.BatchTableSink}, a streaming
{@link Table} requires a
* {@code org.apache.flink.table.sinks.AppendStreamTableSink}, a
* {@code org.apache.flink.table.sinks.RetractStreamTableSink}, or an
* {@code org.apache.flink.table.sinks.UpsertStreamTableSink}.
*
- * @param tableName Name of the registered {@link TableSink} to which
the {@link Table} is
+ * @param tablePath The path of the registered {@link TableSink} to
which the {@link Table} is
* written.
*/
- void insertInto(String tableName);
+ void insertInto(String... tablePath);
Review comment:
This should be `insertInto(String tablePath, String... tablePathContinued)`
also other methods, to enforce at least one argument.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
