twalthr commented on a change in pull request #8404: [FLINK-11476][table]
Create CatalogManager to manage multiple catalogs
URL: https://github.com/apache/flink/pull/8404#discussion_r283802953
##########
File path:
flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/gateway/local/LocalExecutorITCase.java
##########
@@ -229,9 +229,9 @@ public void testCompleteStatement() throws Exception {
final SessionContext session = new
SessionContext("test-session", new Environment());
final List<String> expectedTableHints = Arrays.asList(
- "TableNumber1",
- "TableNumber2",
- "TableSourceSink");
+ "builtin.default.TableNumber1",
+ "builtin.default.TableNumber2",
+ "builtin.default.TableSourceSink");
Review comment:
One additional comment: could we rename the default names to something more
meaningful such as: `default-catalog.default-database.table`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
