twalthr commented on a change in pull request #8404: [FLINK-11476][table]
Create CatalogManager to manage multiple catalogs
URL: https://github.com/apache/flink/pull/8404#discussion_r285979772
##########
File path:
flink-table/flink-table-api-java-bridge/src/main/java/org/apache/flink/table/api/java/BatchTableEnvironment.java
##########
@@ -283,9 +285,13 @@ static BatchTableEnvironment create(ExecutionEnvironment
executionEnvironment) {
*/
static BatchTableEnvironment create(ExecutionEnvironment
executionEnvironment, TableConfig tableConfig) {
try {
- Class clazz =
Class.forName("org.apache.flink.table.api.java.BatchTableEnvImpl");
- Constructor con =
clazz.getConstructor(ExecutionEnvironment.class, TableConfig.class);
- return (BatchTableEnvironment)
con.newInstance(executionEnvironment, tableConfig);
+ Class<?> clazz =
Class.forName("org.apache.flink.table.api.java.BatchTableEnvImpl");
+ Constructor con =
clazz.getConstructor(ExecutionEnvironment.class, TableConfig.class,
CatalogManager.class);
+ CatalogManager catalogManager = new CatalogManager(
+ tableConfig.getBultinCatalogName(),
Review comment:
typo: `getBuiltInCatalogName` and the same for database name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
