Aitozi commented on a change in pull request #8479: [FLINK-11193][State
Backends]Use user passed configuration overriding default configuration loading
from file
URL: https://github.com/apache/flink/pull/8479#discussion_r286922969
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
##########
@@ -295,6 +297,7 @@ public RocksDBStateBackend(AbstractStateBackend
checkpointStreamBackend, boolean
* @param classLoader The class loader.
*/
private RocksDBStateBackend(RocksDBStateBackend original, Configuration
config, ClassLoader classLoader) {
+ this.configuration = config;
Review comment:
Hi, @klion26 I check the code again, only the `priorityQueueStateType` is
configured from configuration, and the type from configuration will be used
first see
```
final String priorityQueueTypeString =
config.getString(TIMER_SERVICE_FACTORY);
this.priorityQueueStateType = priorityQueueTypeString.length() > 0 ?
PriorityQueueStateType.valueOf(priorityQueueTypeString.toUpperCase()) :
original.priorityQueueStateType;
```
And other parameters are all passed by the constructor, so it can work for
the issue i think. but it looks strange indeed(some follow the original
backend, some follow the config first), I will think how to make it better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
