Aitozi commented on a change in pull request #8479: [FLINK-11193][State
Backends]Use user passed configuration overriding default configuration loading
from file
URL: https://github.com/apache/flink/pull/8479#discussion_r289894942
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
##########
@@ -295,6 +297,7 @@ public RocksDBStateBackend(AbstractStateBackend
checkpointStreamBackend, boolean
* @param classLoader The class loader.
*/
private RocksDBStateBackend(RocksDBStateBackend original, Configuration
config, ClassLoader classLoader) {
+ this.configuration = config;
Review comment:
I think we don't have to, I prefer to keep the former style, but only use
the config in user code with higher priority than the default configuration
loading from the file.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
