Aitozi commented on a change in pull request #8479: [FLINK-11193][State
Backends]Use user passed configuration overriding default configuration loading
from file
URL: https://github.com/apache/flink/pull/8479#discussion_r289677082
##########
File path:
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBStateBackend.java
##########
@@ -295,6 +297,7 @@ public RocksDBStateBackend(AbstractStateBackend
checkpointStreamBackend, boolean
* @param classLoader The class loader.
*/
private RocksDBStateBackend(RocksDBStateBackend original, Configuration
config, ClassLoader classLoader) {
+ this.configuration = config;
Review comment:
other config are all following this manner: check the original config
whether set or undefined, if it is not defined then it will look into the
config , at last fallback to the default config which is consistent with the
doc of the `config()`
> Creates a copy of this state backend that uses the values defined in the
configuration for fields where that **were not yet specified** in this state
backend.
But for the `priorityQueueStateType` there is no undefined type, it only has
two: *rocksdb* and *heap*, if we have to follow the manner I think we just have
to add an undefined value for `priorityQueueStateType`, but i am not sure do we
need to do this.
What i am do now is just overriding the config loading from file with the
original statebackend config to solve this problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
