StefanRRichter commented on a change in pull request #8523:
[FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox)
URL: https://github.com/apache/flink/pull/8523#discussion_r287981908
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -1358,4 +1358,19 @@ public void actionsUnavailable() throws
InterruptedException {
mailbox.putMail(actionUnavailableLetter);
}
}
+
+ private class TimerInvocationContext implements
SystemProcessingTimeService.ScheduledCallbackExecutionContext {
+ @Override
+ public void invoke(ProcessingTimeCallback callback, long
timestamp) throws InterruptedException {
Review comment:
Are you sure that it is a good idea to throw the `InterruptedException`
here? It seems more like this is something that is currently hard to handle
appropriately for the caller and should probably be handled as async exception
as well (i.e. smehow stop the task).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
