StefanRRichter commented on a change in pull request #8523:
[FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox)
URL: https://github.com/apache/flink/pull/8523#discussion_r288433058
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -335,9 +335,9 @@ public final void invoke() throws Exception {
// if the clock is not already set, then assign a
default TimeServiceProvider
if (timerService == null) {
ThreadFactory timerThreadFactory = new
DispatcherThreadFactory(TRIGGER_THREAD_GROUP,
- "Time Trigger for " + getName(),
getUserCodeClassLoader());
+ "Time Trigger for " + getName());
Review comment:
If that was the only reason, then it seems ok to remove the CL, but there
would also be no harm in keeping it. My suggestion would be to keep this
cleanup as separate commit in the same PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
