StefanRRichter commented on a change in pull request #8523:
[FLINK-12481][runtime] Invoke timer callback in task thread (via mailbox)
URL: https://github.com/apache/flink/pull/8523#discussion_r287982473
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/StreamTaskTest.java
##########
@@ -794,23 +796,24 @@ public void testOperatorClosingBeforeStopRunning()
throws Throwable {
}
}
- /**
- * Test set user code ClassLoader before calling ProcessingTimeCallback.
- */
@Test
- public void testSetsUserCodeClassLoaderForTimerThreadFactory() throws
Throwable {
- syncLatch = new OneShotLatch();
-
+ public void testThreadInvariants() throws Throwable {
Review comment:
Again, why exactly if this changed if there is even a test to guard the old
behavior? Did you talk to the author of the test if this is acceptable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
