azagrebin commented on a change in pull request #7549: [FLINK-11403][network]
Introduce ResultPartitionWithConsumableNotifier in task for notifying
consumable result partition
URL: https://github.com/apache/flink/pull/7549#discussion_r288169979
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java
##########
@@ -272,8 +239,6 @@ public void finish() throws IOException {
finally {
if (success) {
Review comment:
side comment: strange `success` flag looks redundant, also try/catch block
...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
