azagrebin commented on a change in pull request #7549: [FLINK-11403][network]
Introduce ResultPartitionWithConsumableNotifier in task for notifying
consumable result partition
URL: https://github.com/apache/flink/pull/7549#discussion_r288507065
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java
##########
@@ -212,14 +213,19 @@ protected ResultPartitionWriter createResultPartition(
NetworkEnvironment environment,
int channels) throws Exception {
- ResultPartition resultPartition = new ResultPartitionBuilder()
- .setResultPartitionId(partitionId)
-
.setResultPartitionType(ResultPartitionType.PIPELINED_BOUNDED)
- .setNumberOfSubpartitions(channels)
-
.setResultPartitionManager(environment.getResultPartitionManager())
- .setIOManager(ioManager)
-
.setupBufferPoolFactoryFromNetworkEnvironment(environment)
- .build();
+ ResultPartitionWriter resultPartition = new
ResultPartitionWithConsumableNotifier(
+ new NoOpTaskActions(),
+ jobId,
+ new ResultPartitionBuilder()
Review comment:
nit: would be nice to have a local variable for the original partition
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
