azagrebin commented on a change in pull request #7549: [FLINK-11403][network]
Introduce ResultPartitionWithConsumableNotifier in task for notifying
consumable result partition
URL: https://github.com/apache/flink/pull/7549#discussion_r288176384
##########
File path:
flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/io/benchmark/StreamNetworkBenchmarkEnvironment.java
##########
@@ -213,7 +213,6 @@ protected ResultPartitionWriter createResultPartition(
int channels) throws Exception {
ResultPartition resultPartition = new ResultPartitionBuilder()
- .setJobId(jobId)
Review comment:
We should actually also wrap `resultPartition` here to take wrapping into
account in benchmark tests. Probably with `NoOpTaskActions`, at least forcing
the wrapper to be called.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
