tillrohrmann commented on a change in pull request #8529:
[FLINK-12603][network] Remove getOwningTaskName method from InputGate
URL: https://github.com/apache/flink/pull/8529#discussion_r289840718
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BarrierBuffer.java
##########
@@ -122,8 +124,8 @@
*
* @throws IOException Thrown, when the spilling to temp files cannot
be initialized.
*/
- public BarrierBuffer(InputGate inputGate, BufferBlocker bufferBlocker)
throws IOException {
- this (inputGate, bufferBlocker, -1);
+ public BarrierBuffer(InputGate inputGate, BufferBlocker bufferBlocker) {
Review comment:
It looks as if this constructor is only used for testing. Please annotate
with `@VisibleForTesting`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services