tillrohrmann commented on a change in pull request #8529:
[FLINK-12603][network] Remove getOwningTaskName method from InputGate
URL: https://github.com/apache/flink/pull/8529#discussion_r290201071
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OneInputStreamTask.java
##########
@@ -88,7 +88,8 @@ public void init() throws Exception {
getStreamStatusMaintainer(),
this.headOperator,
getEnvironment().getMetricGroup().getIOMetricGroup(),
- inputWatermarkGauge);
+ inputWatermarkGauge,
+
getEnvironment().getTaskInfo().getTaskNameWithSubtaskAndID());
Review comment:
I think `TaskInfo` has the purpose to encapsulate some user facing
information about the task. That's why it is located in `flink-core`. The
`ExecutionAttempID` and also the `AllocationID` are runtime specific concepts
which should not be part of this class imo. Thus, I would strongly suggest to
not mix concerns and cleanly separate the different aspects. Which components
actually need `getTaskNameWithSubtaskAndID()`? As far as I can tell, it is just
the `UnionInputGate` as well as the `BarrierBuffer`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
