tillrohrmann commented on a change in pull request #8529:
[FLINK-12603][network] Remove getOwningTaskName method from InputGate
URL: https://github.com/apache/flink/pull/8529#discussion_r289842256
##########
File path: flink-core/src/main/java/org/apache/flink/api/common/TaskInfo.java
##########
@@ -67,11 +56,12 @@ public TaskInfo(
checkArgument(indexOfSubtask < numberOfParallelSubtasks, "Task
index must be less than parallelism.");
checkArgument(attemptNumber >= 0, "Attempt number must be a
non-negative number.");
this.taskName = checkNotNull(taskName, "Task Name must not be
null.");
+ this.taskNameWithSubtasks = checkNotNull(taskNameWithSubtasks);
+ this.taskNameWithSubtaskAndID =
checkNotNull(taskNameWithSubtaskAndID);
Review comment:
This seems a bit odd. We are storing three times the task name. I think this
is duplicated information. I think it would be better to rather store the
`taskName`, its index, the number of maximum tasks and its
`ExecutionAttemptID`. If `TaskInfo` contains this, then we could generate the
`taskNameWithSubtaskAndID` based on this information when instantiating the
`One/TwoInputStreamTask`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
