tillrohrmann commented on a change in pull request #8580: [FLINK-12683] Provide
task manager location information for checkpoint coordinator specific log
messages
URL: https://github.com/apache/flink/pull/8580#discussion_r290798044
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -776,16 +789,22 @@ else if (LOG.isDebugEnabled()) {
*
* @param message Checkpoint ack from the task manager
*
+ * @param taskManagerLocation The location of the acknowledge
checkpoint message's sender
* @return Flag indicating whether the ack'd checkpoint was associated
* with a pending checkpoint.
*
* @throws CheckpointException If the checkpoint cannot be added to the
completed checkpoint store.
*/
- public boolean receiveAcknowledgeMessage(AcknowledgeCheckpoint message)
throws CheckpointException {
+ public boolean receiveAcknowledgeMessage(AcknowledgeCheckpoint message,
TaskManagerLocation taskManagerLocation) throws CheckpointException {
Review comment:
`@Nullable`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
