tillrohrmann commented on a change in pull request #8580: [FLINK-12683] Provide 
task manager location information for checkpoint coordinator specific log 
messages
URL: https://github.com/apache/flink/pull/8580#discussion_r290795988
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/LegacyScheduler.java
 ##########
 @@ -526,11 +526,13 @@ public void acknowledgeCheckpoint(final JobID jobID, 
final ExecutionAttemptID ex
                        checkpointId,
                        checkpointMetrics,
                        checkpointState);
+               final Execution currentExecution = 
executionGraph.getRegisteredExecutions().get(executionAttemptID);
 
 Review comment:
   refactor into method `Optional<TaskManagerLocation> 
tryRetrieveTaskManagerLocation(ExecutionAttemptID)` and reuse in 
`declineCheckpoint`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to