tillrohrmann commented on a change in pull request #8580: [FLINK-12683] Provide
task manager location information for checkpoint coordinator specific log
messages
URL: https://github.com/apache/flink/pull/8580#discussion_r290797620
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
##########
@@ -723,14 +724,22 @@ else if (!props.forceCheckpoint()) {
* Receives a {@link DeclineCheckpoint} message for a pending
checkpoint.
*
* @param message Checkpoint decline from the task manager
+ * @param taskManagerLocation The location of the decline checkpoint
message's sender
*/
- public void receiveDeclineMessage(DeclineCheckpoint message) {
+ public void receiveDeclineMessage(DeclineCheckpoint message,
TaskManagerLocation taskManagerLocation) {
if (shutdown || message == null) {
return;
}
+
+ if (taskManagerLocation == null) {
+ throw new IllegalArgumentException("Received
DeclineCheckpoint message " + message.getCheckpointId() +
+ " by task " + message.getTaskExecutionId() + "
of job " +
+ message.getJob() + " while can not find the
task's location information ");
+ }
+
if (!job.equals(message.getJob())) {
throw new IllegalArgumentException("Received
DeclineCheckpoint message for job " +
- message.getJob() + " while this coordinator
handles job " + job);
+ message.getJob() + " at " + taskManagerLocation
+ " while this coordinator handles job " + job);
Review comment:
should be `"... from " + taskManagerLocation`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
