azagrebin commented on a change in pull request #8485: [FLINK-12555] Introduce
an encapsulated metric group layout for shuffle API
URL: https://github.com/apache/flink/pull/8485#discussion_r291036374
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -359,21 +359,14 @@ public Task(
final String taskNameWithSubtaskAndId = taskNameWithSubtask + "
(" + executionId + ')';
- // add metrics for buffers
- final MetricGroup buffersGroup =
metrics.getIOMetricGroup().addGroup("buffers");
-
- // similar to MetricUtils.instantiateNetworkMetrics() but
inside this IOMetricGroup
- final MetricGroup networkGroup =
metrics.getIOMetricGroup().addGroup("Network");
- final MetricGroup outputGroup = networkGroup.addGroup("Output");
- final MetricGroup inputGroup = networkGroup.addGroup("Input");
+ MetricGroup taskShuffleMetricGroup =
networkEnvironment.createTaskMetricGroup(metrics.getIOMetricGroup());
Review comment:
My idea was to expose `TaskShuffleContext
ShuffleEnvironment.createTaskShuffleContext(taskName, execId,
parentMetricGroup)` in `ShuffleEnvironment `. `TaskShuffleContext` would
contain taskName, execId and created in/output metric group as well.
`createPartition/Gate` methods would take the `TaskShuffleContext`. This way
`ShuffleEnvironment ` can create its own metric group once and other task
common parameters are encapsulated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
