azagrebin commented on a change in pull request #8485: [FLINK-12555] Introduce
an encapsulated metric group layout for shuffle API
URL: https://github.com/apache/flink/pull/8485#discussion_r291039807
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -160,10 +169,10 @@ public static NetworkEnvironment create(
singleInputGateFactory);
}
- private static void registerNetworkMetrics(MetricGroup metricGroup,
NetworkBufferPool networkBufferPool) {
+ private static void registerNetworkMetrics(String groupName,
MetricGroup metricGroup, NetworkBufferPool networkBufferPool) {
Review comment:
I would avoid history change in this commit, could be a followup to put all
metric methods into a `NettyShuffleMetricFactory` with constants.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
