azagrebin commented on a change in pull request #8485: [FLINK-12555] Introduce
an encapsulated metric group layout for shuffle API
URL: https://github.com/apache/flink/pull/8485#discussion_r291622614
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java
##########
@@ -388,16 +381,18 @@ public Task(
executionId,
this,
inputGateDeploymentDescriptors,
- metrics.getIOMetricGroup(),
- inputGroup,
- buffersGroup);
+ taskShuffleMetricGroup);
this.inputGates = new InputGate[gates.length];
int counter = 0;
for (InputGate gate : gates) {
inputGates[counter++] = new InputGateWithMetrics(gate,
metrics.getIOMetricGroup().getNumBytesInCounter());
}
+ // we will have to check type of shuffle service later whether
it is NetworkEnvironment
+ //noinspection deprecation
+
networkEnvironment.registerLegacyNetworkMetrics(metrics.getIOMetricGroup(),
resultPartitionWriters, gates);
Review comment:
which is now happening after rebasing onto #8608
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
