zhijiangW commented on a change in pull request #8654: [FLINK-12647][network]
Add feature flag to disable release of consumed blocking partitions
URL: https://github.com/apache/flink/pull/8654#discussion_r291900251
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/ResultPartitionDeploymentDescriptor.java
##########
@@ -58,6 +72,7 @@ public ResultPartitionDeploymentDescriptor(
KeyGroupRangeAssignment.checkParallelismPreconditions(maxParallelism);
this.maxParallelism = maxParallelism;
this.sendScheduleOrUpdateConsumersMessage =
sendScheduleOrUpdateConsumersMessage;
+ this.isManagedExternally =
partitionDescriptor.getPartitionType() == ResultPartitionType.BLOCKING;
Review comment:
Since this property could be got directly based on `ResultPartitionType`,
then another option is not defining this property explicitly in
`ResultPartitionDeploymentDescriptor` and `ResultPartition` could also provide
this property based on internal `ResultPartitionType`.
Otherwise this property might be decoupled with `ResultPartitionType` future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
