zhijiangW commented on a change in pull request #8654: [FLINK-12647][network]
Add feature flag to disable release of consumed blocking partitions
URL: https://github.com/apache/flink/pull/8654#discussion_r291903764
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManagerTest.java
##########
@@ -60,4 +61,26 @@ public void testCreateViewForRegisteredPartition() throws
Exception {
partitionManager.registerResultPartition(partition);
partitionManager.createSubpartitionView(partition.getPartitionId(), 0, new
NoOpBufferAvailablityListener());
}
+
+ @Test
+ public void testExternallyManagedPartitionReleaseIfFlagDisabled() {
+ final ResultPartitionManager partitionManager = new
ResultPartitionManager(false);
+ final ResultPartition partition = new
ResultPartitionBuilder().setIsExternallyManaged(true).build();
+
+ partitionManager.registerResultPartition(partition);
+ partitionManager.onConsumedPartition(partition);
+
+ assertThat(partition.isReleased(), is(false));
+ }
+
+ @Test
+ public void testExternallyManagedPartitionReleaseIfFlagEnabled() {
Review comment:
These two tests could be deduplicated by extracting a boolean value if you
like.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
