zhijiangW commented on a change in pull request #8654: [FLINK-12647][network]
Add feature flag to disable release of consumed blocking partitions
URL: https://github.com/apache/flink/pull/8654#discussion_r292828711
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java
##########
@@ -120,6 +123,7 @@ public ResultPartition(
this.partitionType = checkNotNull(partitionType);
this.subpartitions = checkNotNull(subpartitions);
this.numTargetKeyGroups = numTargetKeyGroups;
+ this.isManagedExternally = isManagedExternally;
Review comment:
I mean we do not add the `isManagedExternally ` property in
`ResultPartitionDeploymentDescriptor` because it is only `ResultPartitionType`
relevant atm and we could get this property directly in `ResultPartition`.
Only if `isManagedExternally` might be generated from other properties except
`ResultPartitionType` in future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
