zentol commented on a change in pull request #8654: [FLINK-12647][network] Add
feature flag to disable release of consumed blocking partitions
URL: https://github.com/apache/flink/pull/8654#discussion_r292825343
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java
##########
@@ -120,6 +123,7 @@ public ResultPartition(
this.partitionType = checkNotNull(partitionType);
this.subpartitions = checkNotNull(subpartitions);
this.numTargetKeyGroups = numTargetKeyGroups;
+ this.isManagedExternally = isManagedExternally;
Review comment:
By uncoupling this field from the field in the descriptor we are running
into the real risk of the logic being out-of-sync, particularly so since the
descriptor is a shared API, while the ResultPartition is an internal class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
