zentol commented on a change in pull request #8654: [FLINK-12647][network] Add
feature flag to disable release of consumed blocking partitions
URL: https://github.com/apache/flink/pull/8654#discussion_r293313508
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionManager.java
##########
@@ -113,10 +126,12 @@ void onConsumedPartition(ResultPartition partition) {
final ResultPartition previous =
registeredPartitions.remove(partition.getPartitionId());
// Release the partition if it was successfully removed
if (partition == previous) {
- partition.release();
- ResultPartitionID partitionId =
partition.getPartitionId();
- LOG.debug("Released partition {} produced by
{}.",
- partitionId.getPartitionId(),
partitionId.getProducerId());
+ if (!partition.isManagedExternally() ||
isReleaseExternallyManagedPartitionsOnConsumption) {
Review comment:
this isn't sufficient; the partition is already removed from
`registeredPartitions` above, leading to wrong behavior of
`getUnreleasedPartitions`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
