zentol commented on a change in pull request #8654: [FLINK-12647][network] Add
feature flag to disable release of consumed blocking partitions
URL: https://github.com/apache/flink/pull/8654#discussion_r293325423
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java
##########
@@ -381,17 +383,20 @@ void onConsumedSubpartition(int subpartitionIndex) {
return;
}
- int refCnt = pendingReferences.decrementAndGet();
-
- if (refCnt == 0) {
+ if (isManagedExternally) {
partitionManager.onConsumedPartition(this);
Review comment:
I think I've found a way to do it; pin() will continue to increment the
refCount by the number of subpartitions, but createSubpartitionsView will
increment it by 1 (if the partition is externally managed).
I'm not sure whether this is a good approach, and what plans people had on
how this should be implemented, so I wouldn't oppose deferring this to a
follow-up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
