bowenli86 commented on a change in pull request #8694: [FLINK-12705][hive]
Allow user to specify the Hive version in use
URL: https://github.com/apache/flink/pull/8694#discussion_r293079728
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/connectors/hive/HiveTableOutputFormat.java
##########
@@ -190,7 +191,8 @@ public void finalizeGlobal(int parallelism) throws
IOException {
StorageDescriptor jobSD =
hiveTablePartition.getStorageDescriptor();
Path stagingDir = new Path(jobSD.getLocation());
FileSystem fs = stagingDir.getFileSystem(jobConf);
- try (HiveMetastoreClientWrapper client =
HiveMetastoreClientFactory.create(new HiveConf(jobConf, HiveConf.class))) {
+ String hiveVersion =
jobConf.get(HiveCatalogValidator.CATALOG_HIVE_VERSION, null);
Review comment:
can this be a member variable that serves in lifetime of the output format?
And we can reuse it in `moveFiles()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
