bowenli86 commented on a change in pull request #8694: [FLINK-12705][hive]
Allow user to specify the Hive version in use
URL: https://github.com/apache/flink/pull/8694#discussion_r293083039
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/client/HiveShimLoader.java
##########
@@ -42,8 +43,10 @@
private HiveShimLoader() {
}
- public static HiveShim loadHiveShim() {
- String version = HiveVersionInfo.getVersion();
+ public static HiveShim loadHiveShim(String version) {
+ if (StringUtils.isNullOrWhitespaceOnly(version)) {
Review comment:
I wonder if we can move the default version assignment up the stack and as
early as possible? HiveShim should be just dealing with whatever version it's
assigned to rather than deciding the default version for callers and catalogs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
