bowenli86 commented on a change in pull request #8694: [FLINK-12705][hive]
Allow user to specify the Hive version in use
URL: https://github.com/apache/flink/pull/8694#discussion_r293085256
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/table/catalog/hive/HiveTestUtils.java
##########
@@ -45,6 +47,10 @@ public static HiveCatalog createHiveCatalog(String
catalogName) {
return new HiveCatalog(catalogName, null, createHiveConf(),
null);
}
+ public static HiveCatalog createHiveCatalog(String name, Map<String,
String> properties) {
Review comment:
minor: can we combine this util and the above one? We may have a bit too
many utils to create a HiveCatalog :) BTW, I think it can just take a hive
version and let callers decide and get whichever version it wants to use
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
