zhijiangW commented on a change in pull request #8654: [FLINK-12647][network]
Add feature flag to disable release of consumed blocking partitions
URL: https://github.com/apache/flink/pull/8654#discussion_r293323818
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartition.java
##########
@@ -381,17 +383,20 @@ void onConsumedSubpartition(int subpartitionIndex) {
return;
}
- int refCnt = pendingReferences.decrementAndGet();
-
- if (refCnt == 0) {
+ if (isManagedExternally) {
partitionManager.onConsumedPartition(this);
Review comment:
The `pin` would increase the counter as the number of subpartitions, but
`createSubpartitionView` only indicates for one of the subpartitions. I need
think through this issue again.
Maybe we could focus on the pin issue in a separate ticket and this PR only
introduces the flag but not changed any current behaviors if you like.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
