zhijiangW commented on a change in pull request #8654: [FLINK-12647][network]
Add feature flag to disable release of consumed blocking partitions
URL: https://github.com/apache/flink/pull/8654#discussion_r293305514
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionTest.java
##########
@@ -100,6 +101,22 @@ public void testAddOnFinishedBlockingPartition() throws
Exception {
testAddOnFinishedPartition(ResultPartitionType.BLOCKING);
}
+ @Test
+ public void
testExternallyManagedBlockingPartitionConsumableMultipleTimes() throws
IOException {
+ final ResultPartition partition = new ResultPartitionBuilder()
+ .setIsExternallyManaged(true)
+ .setResultPartitionType(ResultPartitionType.BLOCKING)
Review comment:
Actually I thought the property of `isExternallyManaged` should control
whether it could be consumed multiple times not related to
`ResultPartitionType`. But in reality the pipelined type could not support this
atm because of the `checkState(readView == null` while
`PipelinedSubpartition#createReadView`. So we can keep the current way for
setting the blocking type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
