tillrohrmann commented on a change in pull request #8654:
[FLINK-12647][network] Add feature flag to disable release of consumed blocking
partitions
URL: https://github.com/apache/flink/pull/8654#discussion_r293357353
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/deployment/ResultPartitionDeploymentDescriptor.java
##########
@@ -48,6 +50,18 @@
/** Flag whether the result partition should send
scheduleOrUpdateConsumer messages. */
private final boolean sendScheduleOrUpdateConsumersMessage;
+ /** Whether the result partition is managed externally.
+ *
+ * <p>An externally managed partition is only released if either
+ * a) the {@link ShuffleEnvironment} is instructed to do so via {@link
ShuffleEnvironment#releasePartitions(Collection)},
+ * b) the production of the partition fails,
+ * c) the {@link ShuffleEnvironment} shuts down.
+ *
+ * <p>An internally managed partition may be released by the {@link
ShuffleEnvironment} at any time it deems
+ * appropriate, typically after it has been fully consumed once.
+ * */
+ private final boolean isManagedExternally;
Review comment:
I think it would be better to name this field `releaseOn/AfterConsumption`
because it better describes what this field influences.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
