tillrohrmann commented on a change in pull request #8654:
[FLINK-12647][network] Add feature flag to disable release of consumed blocking
partitions
URL: https://github.com/apache/flink/pull/8654#discussion_r293355423
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/ResultPartitionFactory.java
##########
@@ -62,13 +63,15 @@ public ResultPartitionFactory(
@Nonnull IOManager ioManager,
@Nonnull BufferPoolFactory bufferPoolFactory,
int networkBuffersPerChannel,
- int floatingNetworkBuffersPerGate) {
+ int floatingNetworkBuffersPerGate,
+ boolean releaseExternallyManagedPartitionsOnConsumption) {
this.partitionManager = partitionManager;
this.ioManager = ioManager;
this.networkBuffersPerChannel = networkBuffersPerChannel;
this.floatingNetworkBuffersPerGate =
floatingNetworkBuffersPerGate;
this.bufferPoolFactory = bufferPoolFactory;
+ this.releaseExternallyManagedPartitionsOnConsumption =
releaseExternallyManagedPartitionsOnConsumption;
Review comment:
in a previous commit we named this field
`isReleaseExternallyManagedPartitionsOnConsumption`. Might be good to be
consistent how we name boolean fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
