tillrohrmann commented on a change in pull request #8654: 
[FLINK-12647][network] Add feature flag to disable release of consumed blocking 
partitions
URL: https://github.com/apache/flink/pull/8654#discussion_r293352017
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/ResultPartitionBuilder.java
 ##########
 @@ -112,6 +114,11 @@ public ResultPartitionBuilder setBufferPoolFactory(
                return this;
        }
 
+       public ResultPartitionBuilder setIsExternallyManaged(boolean 
isExternallyManaged) {
 
 Review comment:
   could be `isExternallyManaged()` which sets `this.isExternallyManaged = 
true`. This makes the API a bit conciser.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to