azagrebin commented on a change in pull request #8759: [FLINK-12868][yarn] Fix
yarn cluster can not be deployed if plugins dir does not exist
URL: https://github.com/apache/flink/pull/8759#discussion_r294349409
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/FlinkDistributionOverlay.java
##########
@@ -75,7 +75,12 @@ public void configure(ContainerSpecification container)
throws IOException {
addPathRecursively(flinkBinPath, TARGET_ROOT, container);
addPathRecursively(flinkConfPath, TARGET_ROOT, container);
addPathRecursively(flinkLibPath, TARGET_ROOT, container);
- addPathRecursively(flinkPluginsPath, TARGET_ROOT, container);
+ if (flinkPluginsPath.isDirectory()) {
Review comment:
Why is it obligatory to set `ENV_FLINK_PLUGINS_DIR` for mesos but not for
yarn? If I do not miss something
`FlinkDistributionOverlay.Builder.fromEnvironment.getObligatoryFileFromEnvironment(ENV_FLINK_PLUGINS_DIR)`
will fail if `ENV_FLINK_PLUGINS_DIR` is not set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
