azagrebin commented on a change in pull request #8759: [FLINK-12868][yarn] Fix
yarn cluster can not be deployed if plugins dir does not exist
URL: https://github.com/apache/flink/pull/8759#discussion_r295261060
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/FlinkDistributionOverlay.java
##########
@@ -75,7 +75,12 @@ public void configure(ContainerSpecification container)
throws IOException {
addPathRecursively(flinkBinPath, TARGET_ROOT, container);
addPathRecursively(flinkConfPath, TARGET_ROOT, container);
addPathRecursively(flinkLibPath, TARGET_ROOT, container);
- addPathRecursively(flinkPluginsPath, TARGET_ROOT, container);
+ if (flinkPluginsPath.isDirectory()) {
Review comment:
As discussed this concern might be not an issue currently because as long as
the user runs our `flink-dist` scripts to submit mesos jobs, `config.sh` has a
default value for `FLINK_PLUGINS_DIR`. The directory there might not exist
though but should work overall with this fix. The plugins shipping can only
break deployments with custom scripts, same as with `lib` and other directories.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
