azagrebin commented on a change in pull request #8759: [FLINK-12868][yarn] Fix
yarn cluster can not be deployed if plugins dir does not exist
URL: https://github.com/apache/flink/pull/8759#discussion_r295165032
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/overlays/FlinkDistributionOverlay.java
##########
@@ -75,7 +75,12 @@ public void configure(ContainerSpecification container)
throws IOException {
addPathRecursively(flinkBinPath, TARGET_ROOT, container);
addPathRecursively(flinkConfPath, TARGET_ROOT, container);
addPathRecursively(flinkLibPath, TARGET_ROOT, container);
- addPathRecursively(flinkPluginsPath, TARGET_ROOT, container);
+ if (flinkPluginsPath.isDirectory()) {
Review comment:
True, we can create a separate ticket. The reason, I brought up it here, is
that the PR basically addresses the problem (or at least some of them) that the
previous deployments (w/o plugins) are not broken after plugins have been
introduced. I guess the previous mesos deployments (same as yarn) do not have
`ENV_FLINK_PLUGINS_DIR` and this case should be probably also tolerated, can be
a separate issue though if you think it needs more discussion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
