xuefuz commented on a change in pull request #8785: [FLINK-11480][hive] Create
HiveTableFactory that creates TableSource/…
URL: https://github.com/apache/flink/pull/8785#discussion_r295796009
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalog.java
##########
@@ -169,6 +172,11 @@ public void close() throws CatalogException {
}
}
+ @Override
+ public Optional<TableFactory> getTableFactory() {
+ return Optional.of(new HiveTableFactory());
Review comment:
Yes. However, for generic tables, it delegates the responsibility to auto
tablefactory discovery service, as you can see from HiveTableFactory
implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
